Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(build): added a sideEffects property for tree shaking package #522

Merged
merged 4 commits into from
Dec 17, 2024
Merged

feat(build): added a sideEffects property for tree shaking package #522

merged 4 commits into from
Dec 17, 2024

Conversation

kkirik
Copy link
Contributor

@kkirik kkirik commented Dec 13, 2024 •
edited by makhnatkin
Loading

Fixes #521

@kkirik kkirik changed the title build: added a side effect property for tree shaking package build: added a sideEffect property for tree shaking package Dec 13, 2024
@kkirik kkirik changed the title build: added a sideEffect property for tree shaking package build: added a sideEffects property for tree shaking package Dec 13, 2024
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

makhnatkin
makhnatkin reviewed Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@makhnatkin makhnatkin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to move the code from default to index.

markdown-editor/src/shortcuts/index.ts

Line 1 in d36c302

import './default';

@kkirik kkirik force-pushed the feat/added-sideEffects-property branch from 6046787 to 099a68b Compare December 17, 2024 10:46
@kkirik
Copy link
Contributor Author

kkirik commented Dec 17, 2024

I propose to move the code from default to index.

markdown-editor/src/shortcuts/index.ts

Line 1 in d36c302

import './default';

I added this file to sideEffects array

@kkirik kkirik force-pushed the feat/added-sideEffects-property branch from 099a68b to b5997d8 Compare December 17, 2024 13:14
kkirik
kkirik commented Dec 17, 2024
View reviewed changes
package.json Show resolved Hide resolved
@makhnatkin makhnatkin changed the title build: added a sideEffects property for tree shaking package feat(build): added a sideEffects property for tree shaking package Dec 17, 2024
@makhnatkin makhnatkin merged commit 03b3962 into main Dec 17, 2024
3 checks passed
@makhnatkin makhnatkin deleted the feat/added-sideEffects-property branch December 17, 2024 17:15
@gravity-ui-bot gravity-ui-bot mentioned this pull request Dec 17, 2024
Merged
PMAWorks pushed a commit to PMAWorks/markdown-editor that referenced this pull request Dec 18, 2024
@kkirik @PMAWorks
feat(build): added a sideEffects property for tree shaking package (g…
cef8738 
…ravity-ui#522)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d3m1d0v d3m1d0v d3m1d0v approved these changes

@makhnatkin makhnatkin makhnatkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add sideEffects for tree shaking
4 participants
@kkirik @gravity-ui-bot @makhnatkin @d3m1d0v